-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Enable jest-watch-typeahead for native tests #51869
Conversation
Allow filtering test by file or test name while in watch mode. This matches existing configuration for the web tests.
Previously, Jest was executed from within a nested directory. Doing so caused the regex patterns used for the `jest-watch-typeahead` to break, as the `../../` would be erroneously included in the file name.
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
Flaky tests detected in 3cfe485. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5367610158
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This is super helpful! Loving the watch mode and filtering 👏 🚀
I've tested this locally, I've also double-checked and it looks like all places where the current test commands were referenced are now updated.
Related PRs
What?
Enable
jest-watch-typeahead
, allowing filtering tests by file name or test namein "watch" mode.
Why?
File name and test name filtering makes it easier to quickly select tests to
run.
How?
jest-watch-typeahead
for native testsPreviously, Jest was executed from within a nested directory. Doing so
caused the regex patterns used for the
jest-watch-typeahead
to break,as the
../../
would be erroneously included in the file name.Testing Instructions
npm run test:native -- --watch
Verify the following package scripts continue to function as expected:
test:native
test:native:clean
test:native:debug
test:native:perf
test:native:perf:baseline
test:native:update
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a