Fix e2e test: ”WP Editor Meta Boxes > Should save the changes” #51884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 95869f0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5372806264
|
stokesman
force-pushed
the
fix/e2e-wp-editor-meta-box
branch
from
95869f0 to
fd10f1f
Compare
|
BTW, I made this back while working on #51824 and forgot to take it off the back-burner. |
Mamaduka
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An improvement of an e2e test.
Why?
To help restore the original intent of the test, reduce some potential for flakiness and abide by Playwright recommendations.
How?
page.reload()that was lost and eliminates a bit of cruft that was introduced in the migration from Puppeteer Migrate wp editor meta box test to Playwright #41519Testing Instructions