Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize defaultBlock, directInsert API's and getDirectInsertBlock selector #52083

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

sethrubenstein
Copy link
Contributor

@sethrubenstein sethrubenstein commented Jun 28, 2023

…elector

What?

This PR stabilizes the __experimentalDefaultBlock, __experimentalDirectInsert API's and __experimentalGetDirectInsertBlock selector.

Why?

This stabilizes defaultBlock so that it can be used by #50982 and #51026. Solves for #52068

How?

Updated references to API's and added deprecation notices to all affected API's and selectors.

Testing Instructions

  1. Everything should work as is.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 28, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sethrubenstein! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@getdave getdave added [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Type] New API New API to be used by plugin developers or package users. labels Jun 30, 2023
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works as expected. I'll wait for someone else to confirm that making these APIs public is a good idea before merging.

@draganescu draganescu merged commit 0b3fb0b into WordPress:trunk Jul 13, 2023
@github-actions github-actions bot added this to the Gutenberg 16.3 milestone Jul 13, 2023
@getdave
Copy link
Contributor

getdave commented Jul 13, 2023

🚀

@sethrubenstein
Copy link
Contributor Author

sethrubenstein commented Jul 13, 2023

Woot, thanks all! I'll work on getting modified #50982 to reflect these new changes.

westonruter added a commit that referenced this pull request Jul 13, 2023
…dd/defer-script-loading-strategy

* 'trunk' of https://github.com/WordPress/gutenberg: (24 commits)
  Add filter to turn off Interactivity API for a block (#52579)
  Search: Remove unnecessary useEffect (#52604)
  Navigation: Simplify the useSelect for useNavigationMenus (#51977)
  Item: Unify focus style and add default font styles (#52495)
  Update Changelog for 16.2.1
  Bump plugin version to 16.2.1
  Avoid passing undefined `selectedBlockClientId` in `BlockActionsMenu` (#52595)
  Cover Block: Fix block deprecation when fixed background is enabled (#51612)
  Nav block: link text color inheritance fixes and tests (#51710)
  Stabilize defaultBlock, directInsert API's and getDirectInsertBlock selector (#52083)
  Fix console warning by improving error handling in Nav block classic menu conversion (#52591)
  Fix: Remove link action of Link UI for draft pages created from Nav block does not correctly remove link. (#52415)
  Lodash: Remove remaining `_.get()` from block editor and deprecate (#52561)
  Fix importing classic menus (#52573)
  ResizableFrame: Make keyboard accessible (#52443)
  Site Editor: Fix navigation menu sidebar actions order and label (#52592)
  correct a typo: sapce -> space (#52578)
  Avoid errors in Dimension visualizers when switching between iframed and non-iframed editors (#52588)
  Patterns: Add client side pagination to patterns list (#52538)
  Site Editor: Make sidebar back button go *back* instead of *up* if possible (#52456)
  ...
@properlypurple properlypurple mentioned this pull request Oct 11, 2023
10 tasks
@bph bph added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Oct 12, 2023
deprecated( '__experimentalDefaultBlock', {
alternative: 'defaultBlock',
since: '6.3',
version: '6.4',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, should we follow up on these deprecations and act on them (remove or extend) as we've reached the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Dev Note Requires a developer note for a major WordPress release cycle [Type] New API New API to be used by plugin developers or package users.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants