Block Editor: Add support for arrays to setImmutably util
#52280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
mcsf,
Mamaduka,
jsnajdr,
flootr,
chad1008,
ntsekouras and
brookewp
This was referenced Jul 4, 2023
|
Size Change: +26 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
add/array-support-set-immutably
branch
from
402a104 to
0d8453a
Compare
mburridge
added
the
[Feature] Block API
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds array support to the pre-existing
setImmutablyutility function.Why?
This is necessary to cover objects with arrays when replacing Lodash's
set()in #52279 and #52278.Related to the Lodash removal project.
How?
We're adding clone support for nested arrays, and allowing numeric keys to set array properties properly.
Testing Instructions
Verify unit tests pass.
Testing Instructions for Keyboard
None
Screenshots or screencast
None