Store: Mutate editor store reference in middlewares application #5229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #5228
This pull request seeks to resolve an issue where side effects are ignored when dispatching to the registered editor store. Because middlewares are applied to the editor store in a non-mutative fashion, the editor module itself uses a different
dispatch
reference from external modules. Therefore, if an external module attempts to dispatch an action on thecore/editor
namespace which has a side-effect attach, the effect will not be triggered.Testing instructions:
This was observed in #5228 where, after updating to use
withDispatch
, it was observed that triggeringfetchReusableBlocks
would not actually fetch the blocks because the effect behavior was not triggered.