Navigation: Fix e2e test failures caused by sidebar title change #52308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ea6b5a1.
glendaviesnz
added
[Type] Bug
|
Size Change: +32 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
@glendaviesnz, I think we should apply a similar fix in |
glendaviesnz
changed the title
will do this as a follow up so we don't hold up getting this patch in |
Yeh, it would be good to know the reason for that. This double return type also had to be handled here recently. |
aaronrobertshaw
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
This fix works well for me and there are no failures when running the e2e spec locally.
There was a similar issue recently that was caused due to the difference in structure returned from useEntityRecord vs useEditedEntityRecord.
It looks like this component uses useEntityProp that relies on the first two under the hood. I've only glanced at that hook so far, so take that with a grain of salt.
|
This might fix the core issue here: #52758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This updates commit ea6b5a1 to add check for object as sometimes
titleis returned as object and sometimes as string.Why?
The original change caused e2e test failures due to the site editor crashing in instances where the title is an object.
How?
Added check for object and string for
titleTesting Instructions
npm run test:e2e:playwright -- --headed specs/editor/blocks/navigation.spec.jscompletes