-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Add inline variation #52525
Search: Add inline variation #52525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this variation be available outside the navigation block? Is there a way to restrict it to the nav block only?
@@ -5,6 +5,7 @@ export const DEFAULT_BLOCK = { | |||
export const ALLOWED_BLOCKS = [ | |||
'core/navigation-link', | |||
'core/search', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would match the current behavior more closely core/search
was not allowed, and only the inline variation is?
Size Change: +168 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
Flaky tests detected in 5a71d65. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5525622783
|
What?
Adds an inline variation the can be used in the navigation block
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast