-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back old Navigation and File blocks JavaScript implementation when Gutenberg is not installed #52553
Add back old Navigation and File blocks JavaScript implementation when Gutenberg is not installed #52553
Conversation
Size Change: -472 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. Thanks for the quick fix, Mario!
Yes, thank you for this quick fix. However...
Can something more tailored than this be provided? Setting the |
…dd/defer-script-loading-strategy * 'trunk' of https://github.com/WordPress/gutenberg: Update Changelog for 16.2.0 Adding support for defined IDs in `TextControl` component (#52028) Bump plugin version to 16.2.0 Revert "Bump plugin version to 16.2.0" Bump plugin version to 16.2.0 Add maxLength to LinkControl search items (#52523) [RNMobile] Update Editor block inserter button styles and default text input placeholder/selection styles (#52269) Site Editor: Reset device preview type when exiting the editing mode (#52566) Trim footnote anchors from excerpts (#52518) Add back old Navigation and File blocks JavaScript implementation when Gutenberg is not installed (#52553) Block Editor: Ensure synced patterns are accounted for in 'getAllowedBlocks' (#52546) Fix md5 class messed up with new block key (#52557) Fix entity cache misses for single posts due to string as recordKey (#52338) Make "My patterns" permanently visible (#52531) Hide site hub when resizing frame upwards to avoid overlap (#52180) Fix "Manage all patterns" link appearance (#52532) Update navigation menu title size & weight in detail panels (#52477) Site Editor Patterns: Ensure sidebar does not shrink when long pattern titles are used (#52547) Site Editor: Restore quick inserter 'Browse all' button (#52529) Patterns: update the title of Pattern block in the block inspector card (#52010)
What?
Add back the old JavaScript files used for the Navigation and File blocks.
Why?
As reported here, in that pull request the old JavaScript files, currently used when Gutenberg is not installed, were removed. This is causing issues for testing and triaging bugs in the 6.3 release.
How?
view.js
files and move the Interactivity API code to a newview-interactivity.js
file.view.js
files depending if Gutenberg is activated or not.Testing Instructions
We can simulate if Gutenberg is activated or not changing the IS_GUTENBERG_PLUGIN variable in the load.php file.
When it is
false
:When it is
true
: