Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining Link UI tests to Playwright #52828

Merged
merged 53 commits into from
Oct 9, 2023
Merged

Migrate remaining Link UI tests to Playwright #52828

merged 53 commits into from
Oct 9, 2023

Commits on Oct 9, 2023

  1. migrate test: will use Post title as link text if link to existing po… 

    …st is created without any text selected
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2b4e8b0 View commit details
    Browse the repository at this point in the history

  2. removed old test

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7375f64 View commit details
    Browse the repository at this point in the history

  3. migrated test: can be created by selecting text and clicking Link

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    19f10e4 View commit details
    Browse the repository at this point in the history

  4. removed old test

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5922929 View commit details
    Browse the repository at this point in the history

  5. migrated test: will not automatically create a link if selected text … 

    …is not a valid HTTP based URL
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c27f885 View commit details
    Browse the repository at this point in the history

  6. updated snapshots and migrated test: can be created without any text … 

    …selected
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5ebaa1d View commit details
    Browse the repository at this point in the history

  7. migrated test: can be created instantly when a URL is selected

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2e4bf04 View commit details
    Browse the repository at this point in the history

  8. migrated test: is not created when we click away from the link input

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    46690c7 View commit details
    Browse the repository at this point in the history

  9. migrated test: can be edited

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    24742f7 View commit details
    Browse the repository at this point in the history

  10. migrated test: can be removed

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    53894d9 View commit details
    Browse the repository at this point in the history

  11. test migrated: allows Left to be pressed during creation when the too… 

    …lbar is fixed to top
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4882d3c View commit details
    Browse the repository at this point in the history

  12. test migrated: allows Left to be pressed during creation in Docked to… 

    …olbar mode
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    10bd381 View commit details
    Browse the repository at this point in the history

  13. migrate test: can be edited with collapsed selection

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5611f0b View commit details
    Browse the repository at this point in the history

  14. migrated test: allows use of escape key to dismiss the url popover

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f3be083 View commit details
    Browse the repository at this point in the history

  15. migrated test: can be modified using the keyboard once a link has bee… 

    …n set
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c5f7d49 View commit details
    Browse the repository at this point in the history

  16. removed comment

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5c5ac41 View commit details
    Browse the repository at this point in the history

  17. improved selector

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4b7aa65 View commit details
    Browse the repository at this point in the history

  18. migrated test: adds an assertive message for screenreader users when … 

    …an invalid link is set
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    86d13f6 View commit details
    Browse the repository at this point in the history

  19. migrated test: should not display text input when initially creating … 

    …the link
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c61b0a1 View commit details
    Browse the repository at this point in the history

  20. migrated test: should display text input when the link has a valid UR… 

    …L value
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    482c2de View commit details
    Browse the repository at this point in the history

  21. migrated test: should preserve trailing/leading whitespace from linke… 

    …d text in text input
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4882bf5 View commit details
    Browse the repository at this point in the history

  22. migrated test: should allow for modification of link text via Link UI

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    245cb45 View commit details
    Browse the repository at this point in the history

  23. migrated test: capture the text from the currently active link even i… 

    …f there is a rich text selection
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8316bb9 View commit details
    Browse the repository at this point in the history

  24. migrated test: should not show the Link UI when selection extends bey… 

    …ond link boundary
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    656a113 View commit details
    Browse the repository at this point in the history

  25. migrated test: should not show the Link UI when selection extends int… 

    …o another link
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5e050f5 View commit details
    Browse the repository at this point in the history

  26. migrated test: should correctly replace targetted links text within r… 

    …ich text value when multiple matching values exist
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7008bf8 View commit details
    Browse the repository at this point in the history

  27. Apply re-wording suggestions from Code Review

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    67e015a View commit details
    Browse the repository at this point in the history

  28. Fix broken test due to upsteam changes

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    83d639c View commit details
    Browse the repository at this point in the history

  29. Create test post using REST

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    54ccc21 View commit details
    Browse the repository at this point in the history

  30. Prefer concretions in tests

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    43f878b View commit details
    Browse the repository at this point in the history

  31. Use requestUtils to create post

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f3ca9b3 View commit details
    Browse the repository at this point in the history

  32. Improve test resilience by using more precise selector

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7dd8c43 View commit details
    Browse the repository at this point in the history

  33. Further improvements to test resilience by using more precise selectors

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5abfc4e View commit details
    Browse the repository at this point in the history

  34. Provide context to usage of getByPlaceholder

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e0c7448 View commit details
    Browse the repository at this point in the history

  35. Update other uses of getByPlaceholder

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1c410d8 View commit details
    Browse the repository at this point in the history

  36. Remove redundant comment

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d98cc13 View commit details
    Browse the repository at this point in the history

  37. Simplify test to essentials and provide context

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    82ea296 View commit details
    Browse the repository at this point in the history

  38. Add util to cover inaccessible selection of Link Popover

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0ff1879 View commit details
    Browse the repository at this point in the history

  39. Improve arrow key under link test

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4fa90c3 View commit details
    Browse the repository at this point in the history

  40. Improve test desc

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    de9e684 View commit details
    Browse the repository at this point in the history

  41. Abstract direct usage of CSS locator in anticipation of refactor

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    500e3df View commit details
    Browse the repository at this point in the history

  42. Make sure test is testing what is says it will

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4cc632f View commit details
    Browse the repository at this point in the history

  43. Use standard helper

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6b9c271 View commit details
    Browse the repository at this point in the history

  44. Shuffle test order

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1e7f8ef View commit details
    Browse the repository at this point in the history

  45. Improve test resilience by avoiding reliance on tab stops

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    87b9c43 View commit details
    Browse the repository at this point in the history

  46. Use standard utils

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    064641d View commit details
    Browse the repository at this point in the history

  47. Replace custom query with standard util

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    cd7a935 View commit details
    Browse the repository at this point in the history

  48. Make it clear which button is being targetted

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    44b832f View commit details
    Browse the repository at this point in the history

  49. Improve test comprehension by using more than simply a period

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    adef5f3 View commit details
    Browse the repository at this point in the history

  50. Increase test comprehensibility but improving assertions

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    eb41c29 View commit details
    Browse the repository at this point in the history

  51. Avoid use of keyboard where not necessary

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6aa08d8 View commit details
    Browse the repository at this point in the history

  52. Apply nits from code review 

    Co-authored-by: Ben Dwyer <ben@scruffian.com>
    @getdave @scruffian
    getdave and scruffian committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d4a6043 View commit details
    Browse the repository at this point in the history

  53. Improve comment

    @getdave
    getdave committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8635538 View commit details
    Browse the repository at this point in the history