-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display keyboard shortcut for command palette in site view #52841
Merged
jameskoster
merged 2 commits into
trunk
from
add/display-command-palette-shortcut-in-site-view
Jul 24, 2023
Merged
Display keyboard shortcut for command palette in site view #52841
jameskoster
merged 2 commits into
trunk
from
add/display-command-palette-shortcut-in-site-view
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
A suggestion for improvement.
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
labels
Jul 21, 2023
Size Change: +6 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jul 24, 2023
jameskoster
deleted the
add/display-command-palette-shortcut-in-site-view
branch
July 24, 2023 17:11
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
Needs User Documentation
Needs new user documentation
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Append the keyboard shortcut to the tooltip that appears when hovering/focusing the Command Palette button in the site editor.
Why?
How?
Make use of
shortcut
prop on theButton
that invokes the Command PaletteTesting Instructions