Site Editor: Use the correct icon for Patterns in sidebar card #52931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Jul 25, 2023
Comment on lines
+38
to
+43
| return { | ||
| title: info.title, | ||
| description: info.description, | ||
| icon: info.icon, | ||
| record: _record, | ||
| }; |
There was a problem hiding this comment.
I've refactored the return values a bit. The info will never have a stable reference, so it's better to return values directly.
Mamaduka
commented
Jul 25, 2023
| @@ -7,7 +7,7 @@ import { store as editorStore } from '@wordpress/editor'; | |||
| import { store as coreStore } from '@wordpress/core-data'; | |||
| import { decodeEntities } from '@wordpress/html-entities'; | |||
| import { __ } from '@wordpress/i18n'; | |||
| import { navigation as navigationIcon } from '@wordpress/icons'; | |||
| import { navigation, symbol } from '@wordpress/icons'; | |||
There was a problem hiding this comment.
Do we always use the Icon suffix, or can we omit it when there's no name collision?
|
Size Change: +35 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Jul 25, 2023
getdave
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #52924.
PR fixes the icon for Patterns in the site editor's sidebar card.
How?
Create a map for record types and icons that need special handling.
Testing Instructions
Screenshots or screencast