-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site editor: Make sure only one Site updated notice displays at a time #53087
Conversation
@@ -107,6 +108,7 @@ export default function SaveHub() { | |||
const saveCurrentEntity = async () => { | |||
if ( ! dirtyCurrentEntity ) return; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other places where we are using the unique id we are not dismissing, but in those cases the notice message is usually unique so obvious it has changed. In this instance, unless we dismiss the notice first it can appear like the subsequent saves may not have been completed as the snackbar appears not to change.
Size Change: +21 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Flaky tests detected in 9f610eb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5687809084
|
What?
Die snackbars die!
Why?
Because @jordesign is not the only one that finds ever multiplying stacks of snacks that tell you the same thing annoying 😄
Fixes: #53016
How?
Adds an id to the snackbar, so it can be dismissed before consecutive saves so that only one appears at a time.
Testing Instructions
Screenshots or screencast
Before:
site-save-snacks-before.mp4
After:
site-edit-snack-after.mp4