Experiment/add custom connections inspector control #53241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/editor-settings.php ❔ lib/experiments-page.php |
cbravobernal
added
the
[Feature] Block API
|
Size Change: +373 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8638dff. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5741859332
|
cbravobernal
commented
Aug 2, 2023
|
Setting the PR as ready for review to not block @michalczaplinski work. |
cbravobernal
requested review from
spacedmonkey,
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
42 tasks
SantosGuillamot
added
the
[Feature] Custom Fields
|
I cannot approve my own PR but I checked latest @michalczaplinski changes and look good to me. Thanks! |
michalczaplinski
deleted the
experiment/add-custom-connectinons-inspector-control
branch
youknowriad
reviewed
Aug 10, 2023
| // of the paragraph block and the `url` attribute of the image block are supported. | ||
| let attributeName; | ||
| if ( props.name === 'core/paragraph' ) attributeName = 'content'; | ||
| if ( props.name === 'core/image' ) attributeName = 'url'; |
There was a problem hiding this comment.
Why not use "block.json" support config instead of hardcoding these. Also the same block can have multiple connected attributes.
There was a problem hiding this comment.
Actually, this should come from the attribute "connection", it should tell which attribute to connect.
There was a problem hiding this comment.
Actually, this should come from the attribute "connection", it should tell which attribute to connect.
Yes! This is just for the first version where we want to support only the url of the image and the content content of the paragraph.
We'll need a different UI here to support connecting multiple attributes per block.
And in general, we'll probably need a different UI altogether for this soon to include searching for custom fields, adding new ones, etc.
youknowriad
reviewed
Aug 10, 2023
86 tasks
mikachan
added
Needs PHP backport
|
Just thinking about the general API design: "content": {
"source": "meta_fields",
"value": "custom_field_meta"
}I'm wondering if As we start to code I feel this might get a bit confusing if it ends up as something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
TBD. I created the PR in case anyone needs to keep working on it.
POC of having a connections attribute that links external or internal sources with blocks, that will be replaced in the frontend by the HTML API.
Now creates this block attributes structure:
{ "connections": { "content": { "source": "meta_fields", "value": "custom_field_meta" } } }Screenshots or screencast