[RNMobile] Avoid navigation container dismissing the keyboard #53270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
I'm getting the following warning (seems I overlooked it because it was only being logged in the debugger 🤦).
Reverting the PR to draft as I noticed that UPDATE: Fixed in d4bdfc7. |
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
geriux
approved these changes
Aug 2, 2023
fluiddot
added
Mobile App - Automation
fluiddot
deleted the
rnmobile/fix/avoid-hide-keyboard-when-opening-block-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Disallowing navigation containers to control the keyboard and dismiss it when navigation occurs.
Why?
This is a regression introduced when updating the React Navigation library via the React Native upgrade 0.71.11.
How?
Pass the prop
keyboardHandlingEnabledto the navigation containers with valuefalse. This should be enough to address the regression, based on the documentation:Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
ios-focus-after-dismissing-bottom-sheet.mp4