Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] - Update LaunchScreen logo and app icon #53395

Merged
merged 4 commits into from
Aug 8, 2023
Merged

[Mobile] - Update LaunchScreen logo and app icon #53395

merged 4 commits into from
Aug 8, 2023

Conversation

geriux
Copy link
Member

@geriux geriux commented Aug 7, 2023 •
edited
Loading

What?

This PR proposes updating the LaunchScreen logo and app icon for the demo iOS app.

Why?

Currently, we have a text logo and the default LaunchScreen placeholders since the project was created. Even though this is the demo app, it's nice to customize it a bit.

How?

It uses the Gutenberg logo and it's applied to the LaunchScreen and app icon.

Testing Instructions

The app should launch as expected with the new icon and LaunchScreen logo.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

Before After
App Icon LaunchScreen

@geriux geriux added [Type] Enhancement A suggestion for improvement. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Mobile App - Automation Label used to initiate Mobile App PR Automation labels Aug 7, 2023
@geriux geriux marked this pull request as ready for review August 7, 2023 15:27
@wpmobilebot wpmobilebot mentioned this pull request Aug 7, 2023
Merged
dcalhoun
dcalhoun approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! 🚀 :shipit:

I might suggest the Gutenberg logo with all of its lines is too busy to use as the app icon. WDYT about changing that or both the icon and launch screen to use the wordmark only? I.e. just the G displayed on gutenberg.run or atop the demo page. To be clear, this proposal should not block this PR.

image

@geriux
Copy link
Member Author

geriux commented Aug 7, 2023

I might suggest the Gutenberg logo with all of its lines is too busy to use as the app icon. WDYT about changing that or both the icon and launch screen to use the wordmark only? I.e. just the G displayed on gutenberg.run or atop the demo page. To be clear, this proposal should not block this PR.

Ohhh nice suggestion! I like that better! I'll push the changes before merging 🚀 Thanks for the review and the suggestion 🙇

@geriux geriux removed the Mobile App - Automation Label used to initiate Mobile App PR Automation label Aug 8, 2023
@geriux geriux merged commit 127a1b7 into trunk Aug 8, 2023
@geriux geriux deleted the rnmobile/update-app-logo branch August 8, 2023 07:37
@github-actions github-actions bot added this to the Gutenberg 16.5 milestone Aug 8, 2023
@twstokes twstokes mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 16.5
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @dcalhoun