Button: Memoize link value passed to the LinkControl #53507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
scruffian and
getdave
and removed request for
ajitbohra
|
Size Change: +11 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is similar to #51155
It is related to #51256.
Pass memoized link value to the
LinkControlcomponent to avoid losing user changes when theButtonEditcomponent rerenders.This is a temporary solution until we find a more permanent one for #51256.
Why?
Referential stability of the
valueobject prevents unnecessary value to state sync.Testing Instructions
Screenshots or screencast
CleanShot.2023-08-09.at.17.30.15.mp4