Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace isSmall prop #53560 #53599

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Replace isSmall prop #53560 #53599

merged 2 commits into from
Dec 18, 2023

Conversation

ddryo
Copy link
Contributor

@ddryo ddryo commented Aug 12, 2023

What?

Replaced the isSmall property with size="small" for some Button components.

Why?

#53560

@skorasaurus skorasaurus added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 3, 2023
This was referenced Nov 3, 2023
Closed
Closed
@mirka mirka requested a review from a team December 15, 2023 11:37
@mirka mirka linked an issue Dec 15, 2023 that may be closed by this pull request
Button: Replace deprecated isSmall property with size="small" property #53560
Closed
@mirka mirka removed a link to an issue Dec 18, 2023
Button: Replace deprecated isSmall property with size="small" property #53560
Closed
mirka
mirka approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm going to leave the issue open because there are a few more "indirect" usages of isSmall, via the DropdownMenu toggleProps and Navigator buttons.

@mirka mirka enabled auto-merge (squash) December 18, 2023 06:48
@mirka mirka merged commit df9f857 into WordPress:trunk Dec 18, 2023
50 of 51 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 18, 2023
@bph bph added the [Package] Block editor /packages/block-editor label Dec 27, 2023
artemiomorales pushed a commit that referenced this pull request Jan 4, 2024
@ddryo @mirka @artemiomorales
Replace isSmall prop #53560 (#53599)
4182f26 
Co-authored-by: Lena Morita <lena@jaguchi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka mirka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees

@ddryo ddryo

Labels
[Package] Block editor /packages/block-editor [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ddryo @mirka @bph @skorasaurus