[a11y] Fix: aria-haspop, aria-expanded attributes on the link format button. #53691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ellatrix,
fluiddot and
dcalhoun
as code owners
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Size Change: +31 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
alexstine
approved these changes
Aug 16, 2023
jorgefilipecosta
deleted the
a11y/fix-aria-haspop-aria-expanded-attributes-on-link-format-button
branch
Thank you for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24796.
Currently, the link format button opens an additional UI but lacks aria-haspopup and aria-expanded tags. This PR resolves the issue.
Currently, the image link button already possesses these attributes, making this PR bring consistency to both elements.
Testing