-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Add user pattern categories to post editor inserter patterns tab #53933
Patterns: Add user pattern categories to post editor inserter patterns tab #53933
Conversation
Size Change: +1.99 kB (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
Flaky tests detected in d2a48ce. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6067216650
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing as advertised for me.
✅ Unsynced patterns display in appropriate user-created categories
✅ Uncategorized patterns show correctly in Uncategorized
Just one small typo I left a comment on.
ca0bc2e
to
81ece3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've given this another test and still appears to be working as advertised for me. Checked with TT3 & TT2 after it was mentioned the pattern lists showed different patterns between this and trunk.
One question though, was there an explicit decision on whether user-created patterns should appear before theme patterns or not?
Currently, after creating a custom pattern it is displayed at the very bottom of the pattern inserter list. Could that be easier for a user to miss?
I have switched it so user patterns appear first - @SaxonF do you have a view on whether this is the best approach? |
@glendaviesnz makes sense to me |
…d filtering (#54007) Co-authored-by: James Koster <james@jameskoster.co.uk>
This was merged with some failing tests, but is going into a feature branch which needs rebasing to get the failing tests resolved, so failing tests will be sorted on that branch prior to merging to trunk. |
…s tab (#53933) Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: James Koster <james@jameskoster.co.uk>
…s tab (#53933) Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: James Koster <james@jameskoster.co.uk>
What?
Add user pattern categories to the post editor block inserter panel
Why?
With the addition of the ability for users to categorize their patterns they will expect them to be ordered by those categories in the inserter.
How?
Used the new
__experimentalBlockPatternCategories
block editor settingThis PR was part of a group of PRs that were merged back into #53835 before being merged into trunk.
A full list of the PRs involved in this work can be found here.
Testing Instructions
Uncategorized
categoryScreenshots or screencast
patterns-cat-editor.mp4