Layout: use override editor style API #54466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +23 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Sep 15, 2023
| return () => { | ||
| deleteStyleOverride( id ); | ||
| }; | ||
| }, [ id, css, setStyleOverride, deleteStyleOverride ] ); |
There was a problem hiding this comment.
I wonder if it makes sense to have a useStyleOverride hook as this seems to be common right? At least an internal one.
youknowriad
reviewed
Sep 15, 2023
| element && | ||
| !! css && | ||
| createPortal( | ||
| <LayoutStyle |
There was a problem hiding this comment.
I don't understand what replaced this component?
There was a problem hiding this comment.
Oh looking at the component itself, it does nothing if it has a "css" prop, it just renders that css. Makes me think we should remove that css prop from the LayoutStyle component and just use <style> directly.
andrewserong
added
[Type] Code Quality
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Uses the API introduced in #52888 for Layout.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast