Try extra wrapping element around floated images #5460
Conversation
This adds a wrapping DIV around a floated image. The reason being — the `figure` element cannot be a child of a `p`, and when you combine that with a `figcaption`, it's hard to create layouts that accommodate both wide and floated images. This PR is an experiment.
|
This fixes #5292. |
|
Would this PR be more digestible if the wrapping element was only added if a theme opted in to wide and fullwide styles? The wrapping element is only really necessary in that environment in the first case. |
Can you explain in what context it would be a child of |
Any child of the p element can be considered an "inline" element, and it was suggested at one point that floats could be inline elements (to inherit the width of the text, in wide environments). But then they can't have the figure element. |
|
But I don't understand when the image block would be a descendent of |
Well in this PR, that wouldn't be the case as I'm wrapping it in a DIV instead. The reason for using a P, would be to make layouts like suggested in https://codepen.io/joen/pen/oEYVXB somewhat more simple, as we can presume that the P element has a centering & max width style on it. I recognize this would not be ideally semantic. |
|
Adding back the "In Progress" label, as I realized that this PR will become moot if #5973 gets merged in without big changes. So it should sort of be one or the other. |
|
Closing, as #5973 which is the other approach, has been merged. |
This adds a wrapping DIV around a floated image. This makes it easier for themers to float images with captions in wide and fullwide layouts.
This description has been edited for clarity.