-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Require a title in the creation modal #54717
Conversation
Size Change: +6 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Flaky tests detected in f79c1d4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6271595138
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 46697a3 |
What?
Fixes #54693.
PR updates pattern creation logic in the modal and makes the title a requirement.
Why?
While WP allows post-type creation without titles, patterns are probably not very useful without them. This also matches the template part creation flow.
P.S. The post-editor template creation uses a fallback title, but I think this method is better.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast