Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: Improve sentence case consistency of labels and notices #54807

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Patterns: Improve sentence case consistency of labels and notices #54807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2fd09d
Patterns: Improve sentence case consistency of labels and notices
aaronrobertshaw Sep 25, 2023
ea974de
Tweak further files
aaronrobertshaw Sep 26, 2023
9c9dba5
Tweak hidden labels for consistency too
aaronrobertshaw Sep 26, 2023
148d06a
Fix failing e2es
aaronrobertshaw Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-patterns-list/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ function BlockPatternList(
onHover,
onClickPattern,
orientation,
label = __( 'Block Patterns' ),
label = __( 'Block patterns' ),
showTitlesAsTooltip,
pagingProps,
},
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/inserter/block-patterns-tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const noop = () => {};

export const allPatternsCategory = {
name: 'allPatterns',
label: __( 'All Patterns' ),
label: __( 'All patterns' ),
};

export const myPatternsCategory = {
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/inserter/search-results.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ function InserterSearchResults( {
const patternsUI = !! filteredBlockPatterns.length && (
<InserterPanel
title={
<VisuallyHidden>{ __( 'Block Patterns' ) }</VisuallyHidden>
<VisuallyHidden>{ __( 'Block patterns' ) }</VisuallyHidden>
}
>
<div className="block-editor-inserter__quick-inserter-patterns">
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-test-utils/src/create-reusable-block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const createReusableBlock = async ( content, title ) => {

// Wait for creation to finish
await page.waitForXPath(
'//*[contains(@class, "components-snackbar")]/*[contains(text(),"Pattern created:")]'
'//*[contains(@class, "components-snackbar")]/*[contains(text(),"pattern created:")]'
);

// Check that we have a reusable block on the page
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/editor/various/pattern-blocks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ describe( 'Pattern blocks', () => {

// Wait for creation to finish.
await page.waitForXPath(
'//*[contains(@class, "components-snackbar")]/*[contains(text(),"Pattern created:")]'
'//*[contains(@class, "components-snackbar")]/*[contains(text(),"pattern created:")]'
);

await clearAllBlocks();
Expand Down
4 changes: 2 additions & 2 deletions packages/list-reusable-blocks/src/components/import-form/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ function ImportForm( { instanceId, onUpload } ) {
case 'Invalid JSON file':
uiMessage = __( 'Invalid JSON file' );
break;
case 'Invalid Pattern JSON file':
uiMessage = __( 'Invalid Pattern JSON file' );
case 'Invalid pattern JSON file':
uiMessage = __( 'Invalid pattern JSON file' );
break;
default:
uiMessage = __( 'Unknown error' );
Expand Down
2 changes: 1 addition & 1 deletion packages/list-reusable-blocks/src/utils/import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ async function importReusableBlock( file ) {
( parsedContent.syncStatus &&
typeof parsedContent.syncStatus !== 'string' )
) {
throw new Error( 'Invalid Pattern JSON file' );
throw new Error( 'Invalid pattern JSON file' );
}
const postType = await apiFetch( { path: `/wp/v2/types/wp_block` } );
const reusableBlock = await apiFetch( {
Expand Down
4 changes: 2 additions & 2 deletions packages/patterns/src/components/pattern-convert-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,12 @@ export default function PatternConvertButton( { clientIds, rootClientId } ) {
pattern.wp_pattern_sync_status === PATTERN_SYNC_TYPES.unsynced
? sprintf(
// translators: %s: the name the user has given to the pattern.
__( 'Unsynced Pattern created: %s' ),
__( 'Unsynced pattern created: %s' ),
pattern.title.raw
)
: sprintf(
// translators: %s: the name the user has given to the pattern.
__( 'Synced Pattern created: %s' ),
__( 'Synced pattern created: %s' ),
pattern.title.raw
),
{
Expand Down
2 changes: 1 addition & 1 deletion packages/patterns/src/store/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const createPatternFromFile =
( parsedContent.syncStatus &&
typeof parsedContent.syncStatus !== 'string' )
) {
throw new Error( 'Invalid Pattern JSON file' );
throw new Error( 'Invalid pattern JSON file' );
}

const pattern = await dispatch.createPattern(
Expand Down
4 changes: 2 additions & 2 deletions ...eusable-blocks/src/components/reusable-blocks-menu-items/reusable-block-convert-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,12 @@ export default function ReusableBlockConvertButton( {
! syncType
? sprintf(
// translators: %s: the name the user has given to the pattern.
__( 'Synced Pattern created: %s' ),
__( 'Synced pattern created: %s' ),
reusableBlockTitle
)
: sprintf(
// translators: %s: the name the user has given to the pattern.
__( 'Unsynced Pattern created: %s' ),
__( 'Unsynced pattern created: %s' ),
reusableBlockTitle
),
{
Expand Down
2 changes: 1 addition & 1 deletion packages/reusable-blocks/src/store/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const __experimentalConvertBlocksToReusable =
: undefined;

const reusableBlock = {
title: title || __( 'Untitled Pattern block' ),
title: title || __( 'Untitled pattern block' ),
content: serialize(
registry
.select( blockEditorStore )
Expand Down
Loading