[RNMobile] Cover block: Avoid exception when adding media after setting the overlay color #54825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
geriux
approved these changes
Sep 26, 2023
fluiddot
deleted the
rnmobile/fix/cover-block-select-media-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an exception produced when adding media on a Cover block that already has an overlay color.
Why?
The exception addressed leads to a crash in the app.
How?
The exception is produced in the handler
onSelectMediadue to a recent change in the shared functionattributesFromMediaintroduced in #54054. Previous to the change,attributesFromMediawas returning a function that updated the attributes upon calling it, but now it just returns the attributes to update. The workaround for the native version is simply to collect the attributes fromattributesFromMediaand update the attributes directly in theonSelectMediahandler.Ideally, we should update the native version of the block to match the logic of the web version. However, in the spirit of addressing the exception sooner than later, we could use this approach and work on the refactor in a separate PR.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A