Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picked commits for WordPress 6.4 Beta 3 #55039

Merged
merged 28 commits into from
Oct 9, 2023
Merged

Cherry-picked commits for WordPress 6.4 Beta 3 #55039

merged 28 commits into from
Oct 9, 2023

Commits on Oct 4, 2023

  1. Add clearer labels and context to BlockPatternsSyncFilter (#54838)

    * Add help text & clearer labeling
    
    * Theme & Plugins
    richtabor authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    05755f3 View commit details
    Browse the repository at this point in the history
  2. Font Library: use snake_case instead of camelCase on fontFamilies end…

    …point param (#54977)
    
    * use snake_case instead of camelCase on endpoint param
    
    * updating test
    matiasbenedetto authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    089c0a3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    020570d View commit details
    Browse the repository at this point in the history
  4. Block Editor: Avoid double-wrapping selectors when transforming the s…

    …tyles (#54981)
    
    * Block Editor: Avoid double-wrapping selectors when transforming the styles
    * Include space in the check
    Mamaduka authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5c01d3d View commit details
    Browse the repository at this point in the history
  5. Don't display the navigation section in template parts details when a…

    … menu is missing (#54993)
    Mamaduka authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    f112f14 View commit details
    Browse the repository at this point in the history
  6. Scripts: Properly use CommonJS for default Playwright config (#54988)

    * Fix path to `globalSetup` in default Playwright config
    
    Oversight from #54856
    
    * `module.exports`
    
    * Fix default export usage
    swissspidy authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d36bd6d View commit details
    Browse the repository at this point in the history
  7. Add template replace flow to template inspector (#54609)

    * Add a modal to allow template switching
    
    * fetch template info
    
    * Allow switching to different patterns
    
    * Allow switching to different patterns
    
    * Add columns
    
    * move availble templates to the actions
    
    * filter for the correct templates
    
    * create the right data structure in the use select
    
    * move to a hook
    
    * inject theme attribute into pattern again
    
    * put the overlay over the top of the dropdown
    
    * fix the pattern to templates hook
    
    * set the template on click
    
    * Also set the blocks
    
    * remove calls to set template with the current template, since setting blocks correctly updates the content in the editor
    
    * serialize blocks so that we have correctly processed template parts
    
    * remove duplicated code
    
    * Remove unnecessary mapping
    
    * refactor
    
    * memoize the patterns
    
    * combine the useSelect
    
    * Update packages/edit-site/src/components/sidebar-edit-mode/page-panels/hooks.js
    
    Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
    
    * Fix ESLint error
    
    * Only show the button is there is more than 1 pattern
    
    * Copy update
    
    * Move the hook to a subdir
    
    * check that there are patterns
    
    * move the check
    
    * remove useCallback
    
    * change condition to show the button
    
    * change condition
    
    * move to use editEntityRecord
    
    * combine filters
    
    * add comments
    
    * Update packages/edit-site/src/components/sidebar-edit-mode/template-panel/replace-template-button.js
    
    Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
    
    ---------
    
    Co-authored-by: Andrei Draganescu <andrei.draganescu@automattic.com>
    Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
    Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
    4 people authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    283f4e7 View commit details
    Browse the repository at this point in the history
  8. List View: Fix performance issue when selecting all blocks (#54900)

    * List View: Fix performance issue when selecting all blocks within the editor canvas in long posts
    
    * Add a comment, rename const
    
    * Move block focus to be performed only once at the root of the list view, instead of within each block
    andrewserong authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    fba6504 View commit details
    Browse the repository at this point in the history
  9. Fix left and right aligmnent in children of Post Template (#54997)

    * Fix left and right aligmnent in children of Post Template
    
    * Add align center styles
    
    * Fix image placeholder disappearing
    tellthemachines authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    2998442 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e2eb0ab View commit details
    Browse the repository at this point in the history
  11. Removed unwanted space from the string (#54654)

    * Update styles.js
    
    Removed unwanted space with translation
    
    * Update deleted-navigation-warning.js
    
    Unwanted space at the end of the string shows translation warning.
    
    * Update inspector-controls.js
    
    Unwanted space at the end of the string shows translation warning
    mujuonly authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d11de67 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3c227eb View commit details
    Browse the repository at this point in the history
  13. [Inserter]: Fix reset of registered media categories (#55012)

    * [Inserter]: Fix reset of registered media categories
    
    * convert `useInserterMediaCategories` to selector and make private
    ntsekouras authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    aca3f6d View commit details
    Browse the repository at this point in the history
  14. Try fixing the flaky 'Toolbar roving tabindex' e2e test (#54785)

    * Try fixing the flaky 'Toolbar roving tabindex' e2e test
    * Add a link in the comment
    Mamaduka authored and mikachan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    202a297 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Fallback to Twitter provider when embedding X URLs (#54876)

    * Fallback to Twitter provider when embedding X URLs
    
    * Avoid processing empty urls when trying a different provider
    
    * Update `react-native-editor` changelog
    # Conflicts:
    #	packages/react-native-editor/CHANGELOG.md
    fluiddot authored and mikachan committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    fcb06c7 View commit details
    Browse the repository at this point in the history
  2. Based on the efforts in #51761, remove caps case from Template Part a…

    …nd prefer sentence case. As all instances of this string are stand alone, it's okay to have Template capitalized as it's the start of a sentence. (#54709)
    ramonjd authored and mikachan committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e790617 View commit details
    Browse the repository at this point in the history
  3. Update pattern import menu item (#54782)

    * Update pattern import menuitem
    
    * Revert label
    jameskoster authored and mikachan committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e93d348 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    baf1425 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    841537f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dac8a21 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0c89d7e View commit details
    Browse the repository at this point in the history
  8. Site Editor: Do not display 'trashed' navigation menus in Sidebar (#5…

    …5072)
    
    * Site Editor: Do not display 'trashed' navigation menus in Sidebar
    
    * Extract selector into a hook
    
    Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
    2 people authored and mikachan committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d0630d0 View commit details
    Browse the repository at this point in the history
  9. Image: Fix Lightbox display bug in Classic Themes. (#54837)

    * If current theme is not a block theme add a default value for $background_color and $close_button_color.
    
    * Set lightbox buttons' background & border to none on hover & focus
    
    * Change logic to support lightbox in classic themes
    
    * Update logic to avoid unnecessary calls
    
    * Add style fixes
    
    * Remove unnecessary code
    
    * Fix close button color
    
    ---------
    
    Co-authored-by: Mario Santos <santosguillamot@gmail.com>
    Co-authored-by: Ricardo Artemio Morales <ric.morales22@gmail.com>
    3 people authored and mikachan committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ae40d77 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Latest Posts: add screen reader title text to Read more links and use…

    … alternative to excerpt_more filter (#55029)
    
    * In the editor: adds a screen reader text span with the post title in the i18n interpolator
    In the frontend: removes excerpt_more filter so we don't override themes and also replaces the default ellipsis with an accessible read more link
    
    * Removing "of" preposition in favour of a semi-colon.
    "Read more" is already translated so using a specifier to add it to the string
    ramonjd authored and mikachan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    11f6a6d View commit details
    Browse the repository at this point in the history
  2. Fix Image block lightbox missing alt attribute and improve accessibil…

    …ity (#55010)
    
    * Move lightbox open button after the image.
    
    * Fix getting the lightbox image alt attribute.
    
    * Improve docblocks.
    
    * Do not render empty role attribute.
    
    * Remove unnecessary aria-hidden attribute.
    
    * Set aria-modal attribute dynamically.
    
    * More meaningful and simpler modal dialog aria-label.
    
    * Increase Close button target size.
    
    * Add enlarged image base64 encoded placeholder.
    
    * Better check for alt attribute as a string.
    
    * Update changelog.
    
    * Move changelog entry to the block library changelog.
    
    * Set lightbox dialog aria-label dynamically.
    
    * Hide background scrim container from assistive technology.
    
    * Remove obsolete code
    
    ---------
    
    Co-authored-by: Ricardo Artemio Morales <ric.morales22@gmail.com>
    # Conflicts:
    #	packages/block-library/CHANGELOG.md
    afercia authored and mikachan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    89f5e33 View commit details
    Browse the repository at this point in the history
  3. Patterns: Add category selector to pattern creation modal (#55024)

    
    ---------
    
    Co-authored-by: Kai Hao <kai@kaihao.dev>
    2 people authored and mikachan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9398b4a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2e4bba1 View commit details
    Browse the repository at this point in the history
  5. Site Editor: Fix template part area listing when a template has no ed…

    …its (#55115)
    
    * Alternative: Fix template part area listing when a template has no edits
    * Fix typos
    Mamaduka authored and mikachan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    95e1f62 View commit details
    Browse the repository at this point in the history