Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document kind, name, plural for entity config #55158

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Oct 9, 2023

Part of #55153
Follow-up to #55103

Documents the kind, name and plural properties of an entity.

Read new section.

@oandregal oandregal requested a review from nerrad as a code owner October 9, 2023 10:46
@oandregal oandregal self-assigned this Oct 9, 2023
@oandregal oandregal added [Type] Developer Documentation Documentation for developers [Package] Core data /packages/core-data labels Oct 9, 2023
@oandregal oandregal mentioned this pull request Oct 9, 2023
13 tasks
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Flaky tests detected in 78600ec.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6455766914
📝 Reported issues:

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

packages/core-data/README.md Outdated Show resolved Hide resolved
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
@oandregal
Copy link
Member Author

There's a playwright test that is failing now dims background image down by 50% with the average image color when an image is uploaded. I'm not sure how it could have anything to do with a change in this README. I've also re-run a few times to clear it, but it doesn't go away. I don't want to fill the job queue with more tasks than necessary, so I'm going to ship this one.

@oandregal oandregal merged commit 6d42053 into trunk Oct 10, 2023
48 of 49 checks passed
@oandregal oandregal deleted the add/docs-for-interacting-with-entities branch October 10, 2023 09:07
@github-actions github-actions bot added this to the Gutenberg 16.9 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Core data /packages/core-data [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants