test: Ignore local environment setup #55172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.65 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 4e111a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6469759333
|
Ah, good catch. Makes sense that the local environment setup only applies when using the development version of the RN bundle 👍 . |
Local environment setup configuration is intended for the development workflow. Applying it to the testing environment produced unexpected outcomes where one's local configuration can cause tests to fail unexpectedly.
dcalhoun
force-pushed
the
test/ignore-local-environment-setup
branch
from
3ac8200 to
4e111a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Do not apply local environment configuration added in #54957 to non-dev environments.
Why?
Local environment setup configuration is intended for the development
workflow. Applying it to the testing environment produced unexpected
outcomes where one's local configuration can cause tests to fail.
How?
Add a
__DEV__conditional to the logic applying thesetup-local.jsconfiguration file.
Testing Instructions
Create a local file:
packages/react-native-editor/src/setup-local.jsAdd the following example configuration to the file to clear out the Demo editor's initial HTML.
Example configuration
Verify the tests should pass on both platforms when running the following
commands.
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a