-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Child Block Test to Playwright #55199
Migrate Child Block Test to Playwright #55199
Conversation
I hope you are doing great! Could you help review this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pooja-muchandikar!
I think some of the locators can be improved. Especially ones that use classes instead of role-based selectors.
Recently, I did a similar migration (#51677); you can check the inner-blocks-allowed-blocks.spec.js
file and use it as a blueprint.
Hi @Mamaduka, Thanks for sharing the feedbacks! All the feedbacks are addressed please review. Thanks! |
Thanks, @pooja-muchandikar! While changes look good, the two tests now check a different thing. They should test a block appender based on the original tests. Let's ensure that migrate tests are still checking for the same thing. Affected tests
Block appender |
@pooja-muchandikar, let me know if you have any additional questions. |
Hi @Mamaduka, I have addressed the feedback and pushed the changes. Please review and let me know if there are any further suggestions. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran the original test in headed mode and adjusted my suggestions. The tests should be passing now.
Hi @Mamaduka Feedbacks addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pooja-muchandikar! One last nitpick and I think we're good to merge once CI checks are green.
What?
Part of #38851.
Migrate child-blocks.test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test:e2e:playwright test/e2e/specs/editor/plugins/child-blocks.spec.js