-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Suggest commands when editing pattern in site editor #55332
Conversation
Size Change: +3 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tested as advertised for me:
✅ Rename pattern icon showed as edit pencil
✅ Rename and Duplicate showed as suggestions on pattern edit page
It looks like it would be reasonably easy to update context to allow for an array, I have a draft PR for this that seems to work. Once this PR is merged it would be useful to add the |
Nice! Thanks for taking a closer look 🚀 I'll give @richtabor a chance to weigh in on the direction we're pursuing and if there are no objections, we'll get this merged to enable your follow-up. |
I think we can move this forward so the proposed follow-up can occur in #55341. |
Addresses: #52651 (comment)
What?
Note: It appears that the loader context is a string value so we can't cover both the
site-editor
andsite-editor-edit
contexts in terms of suggesting these pattern commands, unless we register the same loader twice. This PR errs towards only registering the commands for a single context at presentWhy?
Makes it easier to rename or duplicate patterns after editing one
How?
site-editor-edit
context to the pattern command loaderTesting Instructions
Screenshots or screencast
Screen.Recording.2023-10-13.at.4.17.48.pm.mp4