-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PHP notice when an image with lightbox is deleted in the behaviors file #55385
Fix PHP notice when an image with lightbox is deleted in the behaviors file #55385
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/behaviors.php |
Flaky tests detected in c71c8ec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6534471543
|
@michalczaplinski, @afercia, 👋 , just wanted to double-check whether this should be backported for tomorrow's RC1 once merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @afercia !
Just a note that the behaviors.php
file is kept in Gutenberg ONLY for backwards-compatibility with the previous version of the Lightbox, which used "behaviors" and will be removed in a future GB version. It was never shipped in Core and should not be backported now:
gutenberg/lib/block-supports/behaviors.php
Lines 5 to 7 in 5a04a2b
* This file will NOT be backported to Core. It exists to provide a | |
* migration path for theme.json files that used the deprecated "behaviors". | |
* This file will be removed from Gutenberg in version 17.0.0. |
I removed the [backport to WP RC]
label.
@SiobhyB Nope, should not be backported! |
Thanks for the clarification @michalczaplinski. |
✅ I updated the PHP Sync Tracking Issue for WP 6.5 to note this PR does not require a backport for WP 6.5. |
Follow-up to #55370
What?
Aookues the same fix from #55370 to the behaviiors file.
Why?
How?
Testing Instructions
Not sure how to make a theme use the
behaviors.php
file, but to my understanding thie file may be still used.This change only applies the wame efix for the Image block from #55370
Testing Instructions for Keyboard
Screenshots or screencast