-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Synced Patterns: Ensure title is always visible #55399
Conversation
Size Change: 0 B Total Size: 1.66 MB ℹ️ View Unchanged
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to follow the testing instructions successfully, LGTM! 🚀
I tried restarting the failing PHP tests as well -- I was able to get one previously-failing test to pass, but one is still failing. :| l checked the failures, and agree they seem flaky and unrelated to the changes in this PR. 👍
@SiobhyB I've updated the PR with |
Flaky tests detected in 6ac47e1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6586595900
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed the changes work as expected by following the Testing Instructions 🎊 . I hold on my approval until we solve this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
What?
Fixes #37203, by ensuring the title section of Synced Patterns is alway visible within the editor.
Why?
There are currently certain scenarios where the title section of Synced Patterns is invisible. This happens if a block-based theme with a light background is active, as the native editor displays the light background in contrast with the block's dark mode styles. The same happens if a theme has a dark background and a device's light mode if enabled.
How?
The logic associated with the title section's styles has been updated to use the block based theme's colour scheme.
Testing Instructions
Follow the preparation steps once for each mode (dark/light) and then proceed with the testing steps.
Preparation steps
Testing steps
Testing Instructions for Keyboard
N/A, solely a visual change.
Screenshots or screencast
Dark mode with light background
Light mode with dark background