[RNMobile] Fix error when pasting deeply nested structure content #55613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: +15 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
fluiddot
force-pushed
the
rnmobile/fix/paste-deeply-nested-structure-content
branch
from
1501eff to
750e095
Compare
|
Flaky tests detected in 750e095. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6642782371
|
fluiddot
commented
Oct 26, 2023
Comment on lines
+21
to
+32
| // The following unit tests related to the `raw-handling` API will be enabled when addressing | ||
| // the various errors we encounter when running them in the native version. | ||
| // Reference: https://github.com/WordPress/gutenberg/issues/55652 | ||
| const RAW_HANDLING_UNSUPPORTED_UNIT_TESTS = [ | ||
| 'html-formatting-remover', | ||
| 'phrasing-content-reducer', | ||
| 'ms-list-converter', | ||
| 'figure-content-reducer', | ||
| 'special-comment-converter', | ||
| 'normalise-blocks', | ||
| 'image-corrector', | ||
| ]; |
There was a problem hiding this comment.
We'll enable these unit tests when addressing #55652.
geriux
approved these changes
Oct 31, 2023
|
❓ Quick question, with the test HTML provided in the PR description, should the option to "Ungroup block" work? If I tap it, it doesn't do anything 😅
|
Yeah, it should ungroup the block. I'll take a look 👀, thanks for sharing it ! |
I managed to reproduce it. Looks like there's a bug related to the ungrouping logic used in the |
That sounds good to me, thank you for investigating it! |
fluiddot
deleted the
rnmobile/fix/paste-deeply-nested-structure-content
branch
For reference: #55738 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an error related to pasting content with complex structures that leads to hitting the maximum call stack size specified in Hermes (reference).
Why?
Fixes wordpress-mobile/WordPress-Android#18750 and wordpress-mobile/gutenberg-mobile#6123.
How?
The issue was produced due to the fact that the implementation of
Node.containswas recursive. This function is used as part of the pasting functionality, so when a deeply nested structure is processed, the call stack could grow until it reaches the limit and crashes the editor.gutenberg/packages/react-native-editor/src/jsdom-patches.js
Line 42 in ae769e9
https://github.com/WordPress/gutenberg/blob/1501effca4cf99fd39c30b6f6d0f443e6b090c55/packages/blocks/src/api/raw-handling/utils.js#L128-L134
https://github.com/WordPress/gutenberg/blob/1501effca4cf99fd39c30b6f6d0f443e6b090c55/packages/blocks/src/api/raw-handling/utils.js#L153-L158
https://github.com/WordPress/gutenberg/blob/1501effca4cf99fd39c30b6f6d0f443e6b090c55/packages/blocks/src/api/raw-handling/paste-handler.js#L212
https://github.com/WordPress/gutenberg/blob/1501effca4cf99fd39c30b6f6d0f443e6b090c55/packages/block-editor/src/components/rich-text/index.native.js#L452-L453
The solution proposed is to replace the implementation with a non-recursive approach. In fact, the implementation has been copied from the original polyfill we use in WordPress core for the function
Node.contains(reference 1, reference 2, reference 3). This polyfill is no longer used but we keep a reference (reference).deepFilterNodeListis also recursive, hence we might still get the error after applying this fix. However, it's likely that would happen in very edge cases.Testing Instructions
Click here to display the HTML code
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A