Site Editor Sidebar: Add "Areas" details panel to all templates and update icon #55677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
Size Change: -2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
commented
Oct 28, 2023
Comment on lines
+118
to
+120
| if ( ! templateAreas.length ) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
While working on this PR, I encountered a bug where only the title "Areas" was rendered even when the template had no template parts. This code is to fix that.
|
This PR looks fine to me 👍🏻 I'll wait for @jameskoster to take it for a test run. It does bring more attention to the unexpected state of the back button, whereby clicking back from a template area won't return you to the template. This is the current state in trunk however. |
|
Thanks for the PR, it's working well for me :) My only suggestion would be to use the |
t-hamano
changed the title
|
Thanks for the review, @ramonjd, @jameskoster!
Makes sense, I made such a change in 998a75f. Furthermore, there was a lot of unnecessary code left, so I processed it with 5855481.
|
jameskoster
approved these changes
Oct 30, 2023
|
Sorry for the late reply, I forgot to ship this PR 😅 I updated this PR again with the latest trunk and it still works as intended, so I'd like to merge it as soon as the tests pass. |
|
Flaky tests detected in 6335b09. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7162518066
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54933
What?
This PR adds "Areas" details panel to all templates.
Why?
The "Areas" details panel displays a list of template parts that the current template contains and allows you to quickly access those template parts.
In the current implementation, this panel is included in the
HomeTemplateDetailscomponent, so it only appears if the template'sslugishomeorindex.However, this panel should not be limited to template types.
How?
I took the code for the Areas details panel contained in
HomeTemplateDetailsand split it out as aTemplateAreascomponent. It then renders this component on the sidebar screen of all templates.Update: Additionally, I used the
symbolFilledicon for general template parts so it matches the one you find in the block toolbar / inspector.Testing Instructions