DataViews: extract search from filters
#55722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Feature
|
Size Change: -45 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Oct 31, 2023
| import { ViewGrid } from './view-grid'; | ||
|
|
||
| export default function DataViews( { | ||
| view, | ||
| onChangeView, | ||
| fields, | ||
| filters, | ||
| search = true, | ||
| searchLabel = undefined, |
There was a problem hiding this comment.
Do you think we need to have these props to start with?
There was a problem hiding this comment.
Those are actions consumers may need to do. Happy to remove them if you rather don't allow them for now.
youknowriad
reviewed
Oct 31, 2023
| @@ -10,12 +10,12 @@ import { SearchControl } from '@wordpress/components'; | |||
| */ | |||
| import useDebouncedInput from '../../utils/use-debounced-input'; | |||
|
|
|||
| export default function TextFilter( { filter, view, onChangeView } ) { | |||
| export default function TextFilter( { label, view, onChangeView } ) { | |||
There was a problem hiding this comment.
This should probably be renamed Search or something like that as it's not generic anymore.
There was a problem hiding this comment.
Agreed, though didn't want to do it in this PR to make reviews easier.
youknowriad
approved these changes
Oct 31, 2023
Going to go ahead and merge as I have work that depends on this. These can be follow-ups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Follow up to #55475 (comment)
What?
So far, the text
searchfeature had been modeled as another filter. This PR extract it and makes it standalone.Testing Instructions