Refactor Selected Block Tools #55737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +23 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Nov 2, 2023
| return null; | ||
| } | ||
|
|
||
| if ( shouldShowBreadcrumb || shouldShowContextualToolbar ) { |
There was a problem hiding this comment.
Nit: We could reverse the polarity of this and return null, so that the main return isn't inside a conditional.
scruffian
reviewed
Nov 2, 2023
packages/block-editor/src/components/block-tools/use-selected-block-tool-props.js
Outdated
Show resolved
Hide resolved
…block-tool-props.js
scruffian
force-pushed
the
refactor/selected-block-tools
branch
from
38d6d01 to
a214300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Simplifying the code for the Selected Block Tools.
Why?
The previously named
<SelectedBlockPopover />was also handling the<EmptyBlockInserter />, which is specific to when there is no block selected. The naming of having the<EmptyBlockInserter />be inside of the<SelectedBlockPopover />is confusing, and also does not need most of the computation from the<SelectedBlockPopover />. Splitting it at the parent<BlockTools />level allows for a simpler flow.This is also in anticipation of #54513, but is very useful outside of it. This also makes the large #54513 much easier to review by splitting this into a more isolated chunk.
How?
<SelectedBlockPopover />into<SelectedBlockTools />and<EmptyBlockInserter /><SelectedBlockTools />and<EmptyBlockInserter />into a<useSelectedBlockToolProps />hook.Big thanks to @ajlende who refactored this with me on #54513.
Testing Instructions
There should be no functional change.
Testing Instructions for Keyboard
Screenshots or screencast