-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky 'Switch to Draft' action in Preview e2e tests #55772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
label
Nov 1, 2023
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
mikachan
pushed a commit
that referenced
this pull request
Nov 21, 2023
# Conflicts: # test/e2e/specs/editor/various/preview.spec.js
mikachan
pushed a commit
that referenced
this pull request
Nov 22, 2023
# Conflicts: # test/e2e/specs/editor/various/preview.spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I noticed this failure while re-running e2e tests for #52285.
The 'Switch to Draft' draft action will fail when do document settings sidebar is closed. This update ensures sidebar is open for this test case.
Testing Instructions
CI checks should be green.
Screenshots or screencast
failure-screencast.webm