Query block enhanced pagination: Simplify test setup

[DAreRodz]

What?

Follow-up of #55714.

This PR improves how the Query block tests for the enhanced pagination are initialized.

Why?

To make tests a little bit more performant and straightforward.

How?

Using wpSetUpBeforeClass() and $factory->post->create_many() as suggested in this discussion.

Testing Instructions

N/A

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ phpunit/blocks/render-query-test.php

[gziolo]

I wasn't aware that you could use wpSetUpBeforeClass and wpTearDownAfterClass. It's covered in the docs at https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#slow-fixtures.

It is an abstraction integrated with set_up_before_class and tear_down_after_class which I usually see used instead.

Thank you for working on this enhancement!

[github-actions]

Flaky tests detected in 48732cb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6732737583
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

[getdave]

Reviewing this one it appears the test files are within phpunit/blocks which don't require backporting to WP Core.

✅ I updated the PHP Sync Tracking Issue for WP 6.5 to note this PR does not require a backport for WP 6.5.