Migrate 'meta-attribute-block' e2e tests to Playwright #55830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
talldan and
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 79efbef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6743297825
|
WunderBart
reviewed
Nov 3, 2023
| } ) => { | ||
| await admin.createNewPost(); | ||
| await editor.insertBlock( { name: blockName } ); | ||
| await page.keyboard.type( 'Value' ); |
There was a problem hiding this comment.
I'm wondering if typing immediately after inserting a block can potentially be flaky since we don't have a promise ensuring the block is there and focused (AFAIR there were issues with that before!). What if we returned the inserted block locator from the createBlock so that we can do a simple await expect( block ).toBeFocused()? I've drafted an implementation in #55851.
There was a problem hiding this comment.
Would look more less like this:
const paragraph = await editor.insertBlock( { name: 'core/paragraph' } );
await expect( paragraph ).toBeFocused();
await page.keyboard.type( 'Howdy hoo!');There was a problem hiding this comment.
This should be okay. The editor will automatically focus first focusable element in newly inserted block.
There was a problem hiding this comment.
Is the block insertion synchronous, though? I can see that, e.g., window.wp.data.dispatch( 'core/block-editor' ).insertBlock( x ) returns a promise but we're not really awaiting it 🤔
There was a problem hiding this comment.
Right, maybe we should await that. @kevin940726, WDYY?
I'll keep an eye on the flaky reports for this test, just in case.
WunderBart
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
meta-attribute-block.test.jse2e tests to PlaywrightWhy?
See #38851.
Testing Instructions