-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add menubar role to header when using top toolbar #55910
Conversation
Move isCollapsed state from the block-contextual-toolbar into the site editor header, as it is only needed and related to the site editor header. This is not a state the block toolbar needs to know about. Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
Allows block tools in dom header to overflow scroll using flex-shrink. Every element parent of the scrolling toolbar needs an overflow-x: hidden and flex-shrink: 2 (or higher) value. Also sets the small screen size to have the fixed toolbar underneath the header bar.
There were two forms of the small screen top toolbar -- one when the top toolbar option was on, and one when it was off. Both were intended to look and operate in the same way. Rather than maintain two identical systems, it makes more sense to only have one. This also makes the visual and tab order match for all versions, which is better accessibility too.
Size Change: +49 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This role is not announced on Windows in Firefox with NVDA.
It's kind of crazy to me that there is no easy way to communicate multiple-toolbars to assistive tech.
I swear it had worked before in #54513. I took a look back at that and it was using |
@jeryj No luck. I think the toolbar role is likely overriding the announcement but we've got to keep that. 😞 |
57e2f67
to
ea00096
Compare
What?
Adds a menubar role to the header bar on the post editor, site editor, and widgets editor when using the top toolbar mode.
Why?
Allows for better semantic groupings of the toolbars.
How?
Adds the
menubar
role to the header if using the top toolbar view.Testing Instructions
All visual and keyboard functionality should match trunk.
Check that the header has a
role="menubar"
in the site editor, post editor, and widgets editor.Using a screen reader with the virtual focus on that element should announce that is a menubar.