Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: PHP 8.1 deprecated warning strpos() #56171

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix: PHP 8.1 deprecated warning strpos() #56171

merged 2 commits into from
Dec 5, 2023

Conversation

nk-o
Copy link
Contributor

@nk-o nk-o commented Nov 15, 2023

What?

Fix for PHP warning

Why?

#56169

@nk-o nk-o requested a review from spacedmonkey as a code owner November 15, 2023 20:45
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 15, 2023
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @nk-o! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@alexstine alexstine added the [Type] Bug An existing feature does not function as intended label Nov 16, 2023
dmsnell
dmsnell approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@Mamaduka
Copy link
Member

Hi, @nk-o

Can you rebase this branch on top of the latest origin/trunk? It should resolve issues with CI checks.

@Mamaduka Mamaduka added the Needs PHP backport Needs PHP backport to Core label Nov 30, 2023
aristath
aristath approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mamaduka Mamaduka merged commit 6ab61f6 into WordPress:trunk Dec 5, 2023
49 of 50 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.3 milestone Dec 5, 2023
This was referenced Jan 18, 2024
Closed
Closed
@getdave
Copy link
Contributor

getdave commented Jan 23, 2024

Backport process started in

@getdave getdave mentioned this pull request Jan 25, 2024
Merged
@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

@aristath aristath aristath approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@tellthemachines tellthemachines Awaiting requested review from tellthemachines tellthemachines is a code owner

Assignees
No one assigned
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 17.3
Development

Successfully merging this pull request may close these issues.
7 participants
@nk-o @Mamaduka @getdave @aristath @dmsnell @youknowriad @alexstine