useInnerBlocksProps: stabilise dropZoneElement prop #56313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Code Quality
This was referenced Nov 20, 2023
|
Size Change: -5 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
andrewserong
requested review from
youknowriad,
apeatling,
ramonjd and
tellthemachines
tellthemachines
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Given #56312 and the explanation in these comments this looks like the best solution 👍
Side note: I wonder if we should go through these other unstable props and stabilise or remove them as the case may be (we'll probably have to stabilise as they are in practice public APIs and have been for a while)
|
Wonderful, thanks for the quick review @tellthemachines! 🙇
I'm leaning that way, too. Let's see if we get any further comments overnight, and if not, I'll plan to merge this PR in tomorrow.
Good question: I think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #56308, which sought to make
dropZoneElementprivate, this PR proposes stabilising the prop instead.Happy for any feedback, ideas, or opinions on whether it's better to go private for now, or to stabilise the prop!
Why?
Based on discussion in #56070 (comment) there's a good case to be made that we will need
dropZoneElementas a stable prop inuseInnerBlocksProps. See the prototype in #56312 for an example use case, which would be part of resolving #26049.How?
__unstableDropZoneElementtodropZoneElementTesting Instructions
Same testing steps as #56070: