Migrate 'align hook' e2e tests to Playwright #56480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
Mamaduka
commented
Nov 23, 2023
Comment on lines
104
to
119
| // Verify the markup of the selected alignment was generated. | ||
| let markup = await editor.getEditedPostContent(); | ||
| expect( markup ).toContain( 'alignright' ); | ||
|
|
||
| let blocks = await page.evaluate( | ||
| ( [ content ] ) => { | ||
| return window.wp.blocks.parse( content ); | ||
| }, | ||
| [ markup ] | ||
| ); | ||
| expect( blocks ).toMatchObject( [ | ||
| { | ||
| name: 'test/test-align-true', | ||
| isValid: true, | ||
| }, | ||
| ] ); |
There was a problem hiding this comment.
The other correctly applies the selected alignment and correctly removes the alignment should also have similar assertions, but I've only included it here for now.
I think testing intentions here are more apparent than in the original tests. But it still seems odd to test block serialization/parsing here. WDYT?
Original code:
gutenberg/packages/e2e-tests/specs/editor/plugins/align-hook.test.js
Lines 122 to 127 in cc1870a
There was a problem hiding this comment.
From a user perspective, what happens if a block is invalid? What does the user see?
There was a problem hiding this comment.
On the theme side, they will see a broken layout. In the editor, when markup is invalid and the block has no deprecation handlers in the editor, they will see a notice.
There was a problem hiding this comment.
Hmm, it would be difficult to wait until the notice is not shown, 😅 but maybe we could use some other user-facing stuff there instead of the raw markup?
There was a problem hiding this comment.
Maybe the assertion that re-parsing markup is still valid should be performed by low-level tests. The full-content.test.js integration test already does something similar for core blocks.
Here, we can ensure that the generated markup contains (or does not) the alignment classes. What do you think?
Cc-ing @ntsekouras and @jorgefilipecosta as they worked on the original tests.
There was a problem hiding this comment.
I think it makes perfect sense 👍 .
There was a problem hiding this comment.
I've updated the assertions in add8857.
|
Size Change: +727 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
migrate/align-hook-e2e-tests
branch
from
cc068c0 to
026efa1
Compare
WunderBart
approved these changes
Nov 24, 2023
Comment on lines
104
to
119
| // Verify the markup of the selected alignment was generated. | ||
| let markup = await editor.getEditedPostContent(); | ||
| expect( markup ).toContain( 'alignright' ); | ||
|
|
||
| let blocks = await page.evaluate( | ||
| ( [ content ] ) => { | ||
| return window.wp.blocks.parse( content ); | ||
| }, | ||
| [ markup ] | ||
| ); | ||
| expect( blocks ).toMatchObject( [ | ||
| { | ||
| name: 'test/test-align-true', | ||
| isValid: true, | ||
| }, | ||
| ] ); |
There was a problem hiding this comment.
From a user perspective, what happens if a block is invalid? What does the user see?
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
* Migrate 'align hook' e2e tests to Playwright * Remove old test files * Update generated alignment markup assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
align-hook.test.jse2e test to PlaywrightWhy?
Part of #38851.
Testing Instructions