-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate 'site editor export' e2e tests to Playwright #56675
Conversation
Size Change: -201 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
const promise = page.waitForEvent( 'download' ); | ||
await page.getByRole( 'menuitem', { name: 'Export' } ).click(); | ||
const download = await promise; | ||
expect( download.suggestedFilename() ).toBe( 'emptytheme.zip' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how easy it's to test downloads with PW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯, I love it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it! 🌊
* Migrate 'site editor export' e2e tests to Playwright * Remove old test file * Simplify * Use query argument enabling edit mode
What?
Part of #38851.
PR migrates
site-editor-export.test.js
e2e tests to Playwright.Why?
See #38851.
Testing Instructions