Media upload component: lazy mount #56958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -6 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9fba944. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7173133612
|
youknowriad
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This component initialised the media library on mount/load, while it's only needed when the user presses the button to open it. Let's delay initialising until then. A decent chuck of loading time is coming from this component.
(There's many more instances of the one below for the "large post", this one is larger because of a garbage collection.)
First run: -1% load (first block)
Second run also -1%
Why?
Why do work when it might not be needed?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast