Background image support: Fix duplicate output of styling rules

[andrewserong]

What?

Part of #54336

Fix duplicate output of background image styling rules for the Group block.

Why?

As of WP 6.4, the background image block support exists in core as well as in the Gutenberg plugin. Unlike the other block supports, in Gutenberg, we were missing the remove_filter line to switch off the core behaviour if present, to prioritise the Gutenberg behaviour and allow further development of the block support within the plugin.

How?

• Add a remove_filter line to disable core's callback for the background support if present

Testing Instructions

Test with WP 6.4+

Prior to applying this PR, add a post or page with a Group block and set a background image for it. Save and view the site frontend, and inspect the generated markup — notice that the background-image and background-size:cover rules are duplicated.

With this PR applied, there should only be one background-image and background-size:cover rule in the generated markup.

Screenshots or screencast

Before

After

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/block-supports/background.php

[github-actions]

Flaky tests detected in 783771e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7189603410
📝 Reported issues:

• [Flaky Test] should display the "Manage Fonts" icon #56776 in /test/e2e/specs/site-editor/font-library.spec.js

[ramonjd]

A cunning plan!

Before

After

[andrewserong]

Thanks for the quick review!

[getdave]

✅ I updated this PR with the Backported to Core label to indicate that the backport has successfully merged into WP Core. I also updated the PHP Sync Tracking Issue for WP 6.5.