InnerBlocks: combine store subscriptions #57032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +25 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 552b908. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7211530682
|
ellatrix
commented
Dec 14, 2023
| } = props; | ||
|
|
||
| useNestedSettingsUpdate( | ||
| clientId, | ||
| parentLock, |
There was a problem hiding this comment.
Note that all of these are internal sub hooks for only this component, so it's ok to change them.
ellatrix
force-pushed
the
try/combine-inner-blocks-store-subscriptions
branch
from
58228f5 to
ba095aa
Compare
ellatrix
commented
Dec 14, 2023
| @@ -144,13 +144,13 @@ export function onBlockDrop( | |||
| export function onFilesDrop( | |||
| targetRootClientId, | |||
| targetBlockIndex, | |||
There was a problem hiding this comment.
These functions should probably be rewritten a bit. There's some unused variables like this one, and I think other opportunities to use selector functions in callbacks instead of store subscriptions.
youknowriad
reviewed
Dec 14, 2023
| @@ -116,18 +123,22 @@ function UncontrolledInnerBlocks( props ) { | |||
|
|
|||
| // This component needs to always be synchronous as it's the one changing | |||
| // the async mode depending on the block selection. | |||
There was a problem hiding this comment.
I feel this commit is misplaced now no?
There was a problem hiding this comment.
Yes, it actually doesn't look relevant even in trunk. I think this was from before we created BlockListItems and used the async provider directly here.
youknowriad
reviewed
Dec 14, 2023
| name, | ||
| blockType, | ||
| innerBlocks, | ||
| parentLock, |
There was a problem hiding this comment.
Isn't that a public component? so we're adding props to a public component?
There was a problem hiding this comment.
or I guess it's the "controlled" one that is public and this is fine?
There was a problem hiding this comment.
No, only useInnerBlocksProps is public and a component wrapper around that.
There was a problem hiding this comment.
(this component is not even exported)
youknowriad
approved these changes
Dec 14, 2023
tellthemachines
added a commit
that referenced
this pull request
Dec 18, 2023
bph
added
the
[Feature] Nested / Inner Blocks
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR combines all the store subscriptions within InnerBlock into a single one. Note that the sub hooks are not public APIs but rather utility hooks of for InnerBlocks, so adjusting these is fine.
It also only runs the block context selector when needed.
Why?
First run: -21.5% type
Second run: -20.7% type
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast