DataViews: Mark the new Templates pages as stable #57109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
mcsf,
oandregal,
jameskoster,
jasmussen and
ntsekouras
|
I noticed that the existing page has a "Add template" button at the top, not sure if want to add that button first before merging this one. |
youknowriad
commented
Dec 15, 2023
| @@ -1,92 +1,407 @@ | |||
| /** | |||
There was a problem hiding this comment.
This is just the old dataviews-template.js without any change.
ntsekouras
reviewed
Dec 15, 2023
|
Size Change: -67 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Dec 15, 2023
|
Flaky tests detected in 740d308. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7223074758
|
|
Nice, that was fast. :) |
1 task
bph
added
[Feature] DataViews
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
The idea here is to start getting some real usage feedback about the dataviews, to be completely ready when we reach the beta1 for the new WP release.
Testing instructions