-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InnerBlocks: overlay: remove viewport size condition #57135
Conversation
Size Change: +2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in 5d05410. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7234336076
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. We should be consistent.
What?
I don't understand why we are enabling "click through"/overlay for small screen, but not desktop.
Either we should remove this overlay for small screens too, or add it for all sizes.
I believe this is causing an issue on small screens where you can't immediately focus a list item.
Additionally it has a small but noticeably performance impact because every single block list is checking the viewport size, which is not a cheap operation.
Related:
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast