Commands: Allow disabling and enabling comments #57205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] New API
youknowriad
requested review from
ntsekouras,
a team and
andrewserong
and removed request for
a team
|
Size Change: +7 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
bph
removed
the
[Type] New API
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
priethor
added
[Type] New API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on some list view command, I found that it would be useful to be able to enable/disable commands based on conditions. I know we can already do that using command loaders but it felt like a small devx improvement to allow this in the
useCommandanduseCommandLoaderhooks directly instead.Testing Instructions
Nothing really to test here, it's just an API addition. The API is not used right now but I'm planning to use it in a small follow-up PR.