Pattern Category: change show_tagcloud to false #57212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +31 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
t-hamano
force-pushed
the
fix/tag-cloud-pattern-categorie
branch
from
89b7be3 to
95e8b6b
Compare
Mamaduka
reviewed
Dec 19, 2023
Comment on lines
60
to
62
| return _taxonomies?.filter( | ||
| ( { visibility } ) => visibility?.publicly_queryable | ||
| ); |
There was a problem hiding this comment.
We should avoid using filter, map, and similar actions inside the selector. Plus, getTaxonomyOptions already filters and maps values.
There was a problem hiding this comment.
Yeah, show_tagcloud would do it.
|
Thanks for the review, @Mamaduka!
Oh, I missed that 😅
Indeed. The pattern category is probably also unintentionally displayed in the tag cloud widget. I'll do some more research and then update this PR. |
t-hamano
changed the title
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/block-patterns.php |
t-hamano
added
[Feature] Patterns
|
I updated it to simply add I would like to submit a core ticket and core PR if this change makes sense. |
We will need to eventually for 6.5 - which also means we should move the file under that compat folder. |
t-hamano
force-pushed
the
fix/tag-cloud-pattern-categorie
branch
from
f29d9ff to
80424f0
Compare
Done 👍 |
|
Core Ticket: https://core.trac.wordpress.org/ticket/60119 |
|
Thank you for working on this. Once the code is merged into WP Core please could you
Thank you in advance 🙇 |
t-hamano
added
the
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57211
What?
This PR prevents the selection of taxonomies with publicly_queryable set to false in the Tag Cloud block. As a result, the "Pattern Categories" taxonomy cannot be selected.This PR sets
show_tagcloudtofalsewhen registering a pattern category taxonomy (wp_pattern_category).Why?
I think the Pattern Categories is only used by site administrators to categorize patterns, and should not be displayed on the front end.
How?
Check if thepublicly_queryableproperty istrue. This is also used in the following places:When generating variations based on the registered taxonomy in the Post terms block (See)When creating a new template in the Site Editor (See)Added
'show_tagcloud' =>falsetoregister_taxonomy()parameter.Testing Instructions
Tag Cloud Block
Tag Cloud Widget